Redis sess: fix path for persistent_identifier & compression_threshold#9368
Merged
Conversation
The paths for both `persistent_identifier` & `compression_threshold` are prefixed with `param_`. This is against both the documentation and it does not follow the standard used throughout the configuration. https://github.com/magento/devdocs/blob/develop/guides/v2.0/config-guide/redis/redis-session.md#configure-magento-to-use-redis-for-session-storage
Contributor
Contributor
Author
|
Hey @maghamed, anything else needed from me here? I doubt that anyone is using the incorrectly named variants. Will also need back porting into 2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the paths for both
persistent_identifier&compression_thresholdare prefixed withparam_. This is against both the documentation and it does not follow the standard used throughout the configuration. This PR removes the prefix.Docs:
https://github.com/magento/devdocs/blob/develop/guides/v2.0/config-guide/redis/redis-session.md#configure-magento-to-use-redis-for-session-storage
Fixed Issues (if relevant)
Currently,
persistent_identifierandcompression_thresholdare ignored in the Redis session configuration (the documented options for configuring).Manual testing scenarios
Change
compression_thresholdto 1 (to force compression) and the sessions will not be compressed. Changing the name to beparam_compression_thresholdresults in compression.Contribution checklist